solidjs / solid / 37849731297

77%

main: 89%

push

github

fix(signals): retain store affects registration in production bundles (#3891) (#3915)

* fix(signals): declare the store affects install in sideEffects (#3891)

store/index.ts installs the store half of affects() with a bare
import "./affects.js"; under "sideEffects": false bundlers dropped the
prod/observe module, and affects(store, key) called an unset hook.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): retain store affects registration in production bundles (#3891)

The store half of affects() was installed by a bare `import "./affects.js"`
in store/index.ts, which bundlers drop under "sideEffects": false; prod and
observe apps calling affects(store) crashed. Revert the PR's sideEffects
entries and, following #3912, install the store half from affects() on its
first store target. store/affects.ts no longer imports store.ts: it reaches
getNode and isWrappable through GlobalQueue slots, and the born/witness
hooks through store/hooks.ts, so a store app without affects() and an app
without stores carry none of the other side.

Co-authored-by: Nick <47376425+nickshiro@users.noreply.github.com>
Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Nick <47376425+nickshiro@users.noreply.github.com>

674 of 958 branches covered (70.35%)

Branch coverage included in aggregate %.

996 of 1227 relevant lines covered (81.17%)

28.43 hits per line