kubeflow / trainer / 37816975342

72%

push

github

fix(runtimes): correct runtimeRef field path casing in ClusterTrainingRuntime error messages (#4194)

* fix(runtimes): correct runtimeRef field path casing in ClusterTrainingRuntime error messages

ValidateObjects in pkg/runtime/core/clustertrainingruntime.go builds
validation errors with field.NewPath("spec", "RuntimeRef") — capital R.
The actual JSON field name in the CRD spec is runtimeRef (lowercase r),
which is what TrainingRuntime.ValidateObjects already uses.

A user who references a missing or invalid ClusterTrainingRuntime gets
an error pointing at spec.RuntimeRef, which does not exist in the spec.
Tooling that maps field errors back to the source object (SDKs, UIs,
admission webhooks) will fail to match it.

Fix the three field.NewPath calls at lines 106, 115 and 119 to use
"runtimeRef" and add TestClusterTrainingRuntimeValidateObjectsFieldPath
to confirm the corrected path in both the missing-runtime and
invalid-snapshot cases.

Note: PR #3892 adds tests for ValidateObjects and currently expects the
old capital-R spelling. That expectation will need updating once this
fix lands.

Signed-off-by: Nikhil Bansiwal <nikhilbansiwal3495@gmail.com>

* test(webhooks): update TestValidateCreate to expect lowercase runtimeRef

The webhook test for the "unsupported runtime" case expected
spec.RuntimeRef (capital R), which matched the old incorrect spelling
in ClusterTrainingRuntime.ValidateObjects. Update it to expect
spec.runtimeRef to match the fix in this PR.

Signed-off-by: Nikhil Bansiwal <nikhilbansiwal3495@gmail.com>

* test(runtimes): remove redundant ValidateObjects field path test

Remove TestClusterTrainingRuntimeValidateObjectsFieldPath from
clustertrainingruntime_test.go. The field path is already covered
by TestValidateCreate/unsupported_runtime in trainjob_webhook_test.go,
which was updated in the previous commit to expect the corrected
spec.runtimeRef spelling.

Suggested by andreyvelich in PR review.

Signed-off-by: Nikhil Bansiwal <ni... (continued)

0 of 3 new or added lines in 1 file covered. (0.0%)

3336 of 4621 relevant lines covered (72.19%)

0.84 hits per line