astronomer / astro-cli / 37794938553
45%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 217
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 44.901% (+0.05%) from 44.849%
37794938553

push

github

web-flow 
chore(ci): add deadcode tooling to catch exported orphan funcs (#2127)

* chore: fix latent dead-test bugs uncovered by deadcode tooling

Pre-cleanup so the deadcode tool (added in the next commit) starts
with a zero baseline.

- `astro-client-core/client.test.go` and
  `astro-client-iam-core/client.test.go` were named `.test.go`
  instead of `_test.go`, so Go's test infrastructure silently never
  picked them up. Their `TestNewCoreClient` / `TestNewIamCoreClient`
  functions have been dead since they were introduced (PRs #873 and
  #1444). Renaming surfaces the tests; both pass.
- `cmd/api/describe_test.go` had an unused `strPtr` helper.
- `houston/suite_test.go` defined `SetupSuite` as a free function;
  testify's suite framework only invokes it via the `SetupAllSuite`
  interface, i.e. as a method on `*Suite`. Convert to a method so the
  test config actually initializes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(ci): add deadcode tooling

Add a whole-program dead-function check using
`golang.org/x/tools/cmd/deadcode` to catch exported orphan funcs that
`golangci-lint`'s in-package `unused` analyzer cannot. This is the
analogue of astro-desktop's setup.

How it's wired:
- `scripts/check-deadcode.sh` runs `deadcode -test` and fails on any
  finding within the cli's binary-style directories (`cmd/`, `airflow/`,
  `cloud/`, `software/`, `config/`, `settings/`, `houston/`, etc.).
  Library sub-modules (`pkg/airflowrt`, `pkg/proxy`, `pkg/astroauth`,
  `pkg/telemetry`, `astro-client-platform-core`) and the rest of `pkg/`
  are excluded because they are consumed by external Go modules
  (e.g. astro-desktop) — reachability from `cmd/astro/main` is not a
  correctness signal for them.
- `prek.toml` gains a `deadcode` hook that pins
  `golang.org/x/tools/cmd/deadcode@v0.27.0` and runs the script.
- `make lint` now runs `make lint-go` (golangci-lint) +
  `make lint-deadcode` (the new hook). CircleCI's `lint` job runs both
... (continued)

26988 of 60105 relevant lines covered (44.9%)

9.67 hits per line

Jobs
ID Job ID Ran Files Coverage
1 37794938553.1 217
44.9
GitHub Action Run
Source Files on build 37794938553