supabase / supabase-flutter / 37789579735

92%

push

github

fix: honor Retry-After and abort signals in retries, and share one retry loop (#1929)

Fixes
[SDK-2132](https://linear.app/supabase/issue/SDK-2132/fix-honor-retry-after-and-abort-signals-in-retries-and-share-one-retry).

## What

- **One retry loop.** PostgREST now uses the shared `retry()` from
`supabase_common` instead of its own loop. `retry()` gains a
`retryIfResult` hook, so a client can retry on what the server answered
(PostgREST's `503`/`520`) and still get that response back once the
retries run out. PostgREST keeps retrying a
`PostgrestTransportException`, as it does on main.
- **`Retry-After` is honored.** `retry()` takes a `retryAfter` hook, and
the new `parseRetryAfter` reads the header as delta seconds or an HTTP
date. Like in Swift, a date that is not in the future, a negative value,
or garbage falls back to the jittered backoff. A requested delay is
capped at `SupabaseRetryOptions.maxDelay`.
  - PostgREST reads the header from a retryable response.
- Auth: `AuthRetryableApiException` gets a `retryAfter` getter, parsed
from the `headers` it now carries, and the token refresh waits that
long. Its next-tick deadline check uses the same delay, capped at
`maxDelay`.
- Storage only retries transport failures that have no response, so
nothing changes there.
- **Abort signals cut the backoff short.** PostgREST waited out its
backoff with a plain `Future.delayed`. It now passes its abort signal to
the shared loop, so aborting during the backoff ends the request at once
instead of waiting out the delay.

## Notes

- `AuthRetryableApiException.retryAfter` is registered in
`sdk-compliance.yaml`. The rest is in `supabase_common`, which the
capability scan excludes.
- `supabase_common` now depends directly on `http_parser`, which `http`
already pulls in, to parse the HTTP date.

## Tests

- `supabase_common`: `retryIfResult`, `retryAfter` (including the
`maxDelay` cap and an abort during that delay) and `parseRetryAfter`.
- `postgrest`: a `Retry-Aft... (continued)

49 of 49 new or added lines in 4 files covered. (100.0%)

9452 of 10307 relevant lines covered (91.7%)

5.25 hits per line