m-lab / autojoin / 37787892233

70%

push

github

feat(register): add output dir for credentials (#108)

This patch adds a new flag: `-output-secure`. Its default value is
the value used by `-output`, for backward compatibility with
deployments that only specify the `-output` flag.

The purpose of this patch is to allow a consumer like `byos-debian`
to emit the service account key (and possibly other secrets in
the future) into distinct dirs with distinct permissions.

In turn, this ensures that network measurement services such as
the `ndt-server` cannot read the service account key, which is
anyway a secret it should not have access to, while still being
able to source the public files it requires.

We named the flag `-output-secure=` (as opposed to something
like `-secure-output=`) because we want it to sort near the
`-output=` flag for additional `-h/-help` clarity.

0 of 5 new or added lines in 1 file covered. (0.0%)

1254 of 1757 relevant lines covered (71.37%)

0.79 hits per line