m-lab / autojoin / 37787503301

70%

main: 70%

Build Type

Pull #109

github

Committed by bassosimone

Commit Message

fix(register)!: handle json.Unmarshal error

This patch updates `cmd/register/main.go` to handle
`json.Unmarshal` errors, which are possible depending
on what the response looks like. For example, a
truncated response could cause `Unmarshal` to fail.

We use `rtx.Must`, which logs and exits `1`.

While there, prefer an error message and `Exit(1)` to
panicking when the `register` API call failed.

While there, notice that the response has many pointers,
and act accordingly. Make sure it's well formed to
avoid null dereferences a few lines below.

BREAKING CHANGE: `panic` exits with exit code `2` but I'm
not convinced about keeping `2` in the new code: `2` is
usually reserved for "usage error", and in the current
codebase makes sense for "validating" input quickly, while
`1` seems a better semantic translation of "the response
does not look good, sorry, goodbye!".

Pull Request Pull Request #109: fix(register)!: handle json.Unmarshal error

Coverage Stats

0 of 21 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

1254 of 1772 relevant lines covered (70.77%)

0.78 hits per line