decentraland / marketplace / 37777487510

68%

push

github

feat: warn users about orders cancelled by the marketplace contract upgrade (#2736)

* feat: warn users about orders cancelled by the marketplace contract upgrade

Pausing OffChainMarketplace V1/V2 and bumping their contract signature index cancels every open order signed on them. When the cancelled-orders-banner flag is on, the connected wallet's cancelled trades are fetched from the marketplace server (signed request) and a dismissible banner lists them with a link to re-create each one: sell page for NFT listings, bid pages for bids, and the Builder collection for item listings.

Dismissal is stored per wallet and count, so new cancellations show it again.

* feat: mark cancelled item listings as re-created in the builder

Item listings are primary sales, which the Marketplace can't set up, so
their Re-create opens the creator's collection in the Builder. Make that
visible: an external-link icon on the button, a "re-created in the
Builder" note next to the order type, and a line in the list's intro.

* feat: page through every cancelled order in the review modal

The modal only showed the first 100 cancelled orders. It now loads the
next page (skip = loaded count, deduplicated by id) as the user nears the
end of the list, with a loading row, a retry on failure and a "loaded"
hint. The list scrolls inside the modal so hundreds of rows stay usable.

Re-creating a listing or a bid drops the matching cancelled order and
decrements the total, mirroring the server, which stops returning it.
The banner dismissal now holds while the count only goes down, and the
banner no longer remounts (closing the modal) when the total changes.

* fix: price usd-pegged cancelled orders through the mana oracle

V2 listings can be USD-pegged, so their amount is USD wei. The review
modal rendered it as MANA wei; it now goes through PeggedManaPrice with
the trade's own marketplace contract, like ListingPrice does.

price.assetType is typed as TradeAssetType.

* fix: re-show... (continued)

4561 of 8380 branches covered (54.43%)

Branch coverage included in aggregate %.

177 of 180 new or added lines in 17 files covered. (98.33%)

9965 of 13075 relevant lines covered (76.21%)

117.41 hits per line