kontron / python-ipmi / 37773332561

95%

push

github

sdr: reject out of range values of signed sensors

convert_sensor_value_to_raw() checked the range of the raw value after
the conversion to 1's or 2's complement. This conversion maps any
negative value into 0x80..0xff, and positive values from 128 to 255
passed the check, although they are negative raw values of a signed
sensor. A value out of range silently became a wrong raw value, e.g.
200 became 0xc8 (-56) for a 2's complement sensor, and could be set as
a threshold.

Check the range of each data format before the conversion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

7918 of 8537 relevant lines covered (92.75%)

5.56 hits per line