SAP / ui5-project / 37767772514

96%

main: 96%

push

github

[FIX] Build crashing when the consumer has more than 1 resolved versions of `ajv` package (#887)

JIRA: CPOUI5FOUNDATION-1374

`@ui5/project` registers the `ajv-errors` plugin on its `Ajv` instance,
but `ajv-errors` imports its **own** copy of `ajv` at load time instead
of using the instance it's given. When a consumer's tree has two `ajv`
copies, the two bind to different module instances, AJV's
`instanceof`-based codegen breaks, and `ui5 build` crashes
(`SyntaxError: Unexpected token ':'` — see
[ajv-validator/ajv-errors#157](https://github.com/ajv-validator/ajv-errors/issues/157)).
We can't fix this from the consumer side since `@ui5/project` is itself
a dependency.

Vendoring `ajv-errors` **inside** `@ui5/project` makes its
`require("ajv")` resolve to the **same `ajv`** that `validator.js` uses
— one module instance, so the mismatch can't happen regardless of the
consumer's dependency tree. Follows the existing `serve-index` fork
precedent; temporary until upstream lets consumers inject `ajv`.

1466 of 1613 branches covered (90.89%)

Branch coverage included in aggregate %.

43 of 152 new or added lines in 2 files covered. (28.29%)

2877 of 3075 relevant lines covered (93.56%)

136.62 hits per line