1887
93%
master: %

Ran 06 Oct 2016 08:46PM UTC

Jobs 2

Files 95

Run time 1min

Badge

Embed ▾

pending completion

Build # 1887

Build Type

Pull #383

travis-ci

Committed by

web-flow

Commit Message

inbound: Start() should accept a ServiceConfig

This changes `Inbound.Start` to accept a `ServiceConfig` rather than a
`Handler`. The `ServiceConfig` contains the name of the service and the
registry of procedures.

The motivation for this change is to give inbounds more information about the
methods they are handling. This is needed for oneway (#327, #378) because the
handler types are different and the inbound needs to know that in advance
based on the procedure name.

The service name is attached to the `ServiceConfig` so that the TChannel
transport can instantiate its own Channel with that service name if necessary.

This should also allow @willhug to drop the type casting of the `Handler` to
`Registry` in #354 and just use the `Registry` directly.

Pull Request Pull Request #383: inbound: Start() should accept a ServiceConfig

Run Details

4326 of 4667 relevant lines covered (92.69%)

1.96 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	1887.3 (TYPE=test)	06 Oct 2016 08:46PM UTC	0	92.69	Travis Job 1887.3
4	1887.4 (TYPE=test)	06 Oct 2016 08:47PM UTC	0	92.69	Travis Job 1887.4

Source Files on build 1887

Detailed source file information is not available for this build.

yarpc / yarpc-go / 1887
93%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1887

yarpc / yarpc-go / 1887 93% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1887

yarpc / yarpc-go / 1887
93%
master: %

README BADGES
x