aio-libs / multidict / 37758426748

86%

push

github

Specialize the compact table helpers per class (#1748)

<!-- Thank you for your contribution! -->

## What do these changes do?

Splits `compact_key_identity()`, `compact_entry_identity()`,
`compact_key_hash()` and `compact_entry_hash()` into `_cs` and `_ci`
versions, dropping the `bool ci` argument. `HTKEYSITER_FIND_COMPACT()`
becomes `HTKEYSITER_FIND_COMPACT_CS()` and `_CI()`, and every caller
picks one before its probe loop. Every other loop over a compact table
also has one copy per class: the lock-free find (now one function per
table kind, with `_compact_entry_matches_cs()` and `_ci()`),
`md_walk_all()`, index rebuilds, the moves to `KIND_ANYSTR`,
`to_dict()`, `extend(self)`, the post-update deletes, and the `==`
scans, which go from 4 kind pairs to 9.

The C extension only; the pure-Python backend has no table kinds.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No. The per-class loop bodies are generated by local macros where they
are longer than a few lines. The `check_inlining.py` rule for
`_compact_entry_matches` now covers both halves.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` on debug builds (`MULTIDICT_DEBUG_BUILD=1`), CPython
3.14.7: 4076 passed / 182 skipped (GIL), 4061 passed / 197 skipped (FT).
The pure-Python leg and 3.10 were not run; no Python code changed.
Inlining: `tools/check_inli... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9326 of 10194 relevant lines covered (91.49%)

1.83 hits per line