QuantEcon / QuantEcon.py / 37706684343

94%

Build Type

push

github

Committed by web-flow

Commit Message

DEPR: deprecate fetch_nb_dependencies and demote requests to an extra (#953)

* DEPR: deprecate fetch_nb_dependencies and demote requests

Deprecates `quantecon.util.notebooks` in 0.12.0 for removal in v1.0, and
moves `requests` out of the mandatory dependency set into a `notebooks`
extra that is removed with the module.

`requests` served exactly one call site in the package. The function has
no remaining constituency: no usage across lecture-python.myst,
lecture-python-advanced.myst, lecture-python-intro or
lecture-python-programming.myst, and the callers that exist are dormant
notebooks descending from two 2017-era demos. Its default remote,
QuantEcon/QuantEcon.notebooks, was last pushed 2023-07-15. Data still
needed moves to QuantEcon/data-lectures.

Calling the function emits a DeprecationWarning attributed to the
caller's frame. Where `requests` is absent the lazy import raises an
ImportError naming the extra. The stale 2016 TODO block, which no longer
described the code, is replaced by the deprecation directive.

Adds `r.raise_for_status()` as harm reduction for the module's final
release: #870 reported that a missing remote path saved GitHub's 404 HTML
page under the requested filename and reported success. Verified against
the reported reproducer, which now raises HTTPError and writes no file.
The other three defects in #870 are left unfixed, the function being
scheduled for removal.

Part of #880. Supersedes #870, #904 and #905, all closed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* TEST: skip the notebooks tests without requests; set the deprecation version to 0.13.0

Addresses two Copilot comments: the module is skipped with importorskip
where requests (now the notebooks extra) is not installed, and the
teardown no longer fails when raise_for_status left no file behind. The
deprecation version becomes 0.13.0, the next release, matching #979.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

C... (continued)

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

5602 of 5954 relevant lines covered (94.09%)

0.94 hits per line