waldbaer / node-red-persistent-values / 37679115191

100%

push

github

Fix crash of value nodes with an unknown value reference (#36) (#36)

Issue: After a value was deleted from a configuration, value nodes still
referencing it threw a `TypeError` at deploy or on incoming messages
instead of reporting the broken reference.

A value node whose value reference doesn't match any value of its
configuration crashed instead of reporting the problem. This happens
when a value is deleted from a configuration while value nodes still
reference it and are not opened and saved again.

- With a valid `valueId` that the configuration doesn't contain, setup
  threw a `TypeError` on the missing value's `name`, and Node-RED
  reported the raw exception at deploy.
- With the deprecated reference by name and a name the configuration
  doesn't contain, setup succeeded, but every message without a dynamic
  value override threw a `TypeError`, and so did setup with block-if
  enabled.

Setup now checks that the reference resolves, for both reference forms.
If it doesn't, the node logs `Incorrect or inconsistent configuration`
and registers no input handler, as for a missing configuration or a
malformed UUID. A node with an unresolvable reference by name therefore
also ignores messages with a dynamic value override, which previously
worked by accident.

Includes the OpenSpec change fix-runtime-unknown-value-reference.

175 of 175 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

307 of 307 relevant lines covered (100.0%)

141.15 hits per line