waldbaer / node-red-persistent-values / 37673913049

100%

push

github

Fix value node edit dialog changing the node before Done (#34)

The change handlers of the configuration and value select fields in the
value node's edit dialog wrote the selected configuration name, value ID
and value name directly to the edited node instead of only to the
dialog's hidden input fields. The node therefore changed while the
dialog was still open:

- Switching to a configuration that doesn't contain the selected value
  cleared the node's value reference, so switching back to the original
  configuration selected no value.
- Cancel kept these changes, because Node-RED only discards the input
  fields, not properties written to the node.
- Done records a change only when an input field differs from the node.
  Selecting another value of the same configuration was therefore not
  recorded: the Deploy button stayed disabled and undo was not possible.

The handlers now write only to the input fields, which Node-RED copies
to the node on Done. While the dialog is open, the node keeps its stored
value reference, so the value list selects it again whenever the
selected configuration contains it. With no value selected, Done still
clears the reference and the editor marks the node as invalid, as
before.

The configuration change handler also assigned the undeclared variable
`backendConfig`. Because the editor scripts are not in strict mode, this
created a global `window.backendConfig` that leaked the last loaded
configuration into the whole Node-RED editor. It is now a local `const`.

Verified manually in Node-RED 5.0.7. Includes the OpenSpec change
fix-editor-dialog-state.

173 of 173 branches covered (100.0%)

Branch coverage included in aggregate %.

304 of 304 relevant lines covered (100.0%)

139.79 hits per line