solidjs / solid / 37670255199

76%

main: 89%

Build Type

push

github

Committed by web-flow

Commit Message

frames: A0 correctness pass, part 2 — park, hydrateWindow, declared records, error propagation, fragment ownership, server half, generic hydration pins (#3849)

* fix(solid): a claim reads the trace's snapshot; the backlog lands after hydration ends (frames-rulings 3.6 (iii), the 3e port)

S1's third commit (9927ddddd) ported onto next, minus its `claiming` hint:

- `materializeContainerTrace` parks a replayed backlog beyond the snapshot
  (`limit = 1`) until hydration ends — `onHydrationEnd`, the next microtask
  when none is in progress — then releases it with a version bump so the
  compute drains the backlog as one ordinary update. A trace is materialized
  at a fill's arg-read; when that fill CLAIMS adopted markup the snapshot is
  what the markup was rendered from, the claim trusts the markup (a text
  hole is never rewritten during a claim), and a store already past it left
  the DOM diverged for good. Release order (3.2): claim → the frame's hold
  release → done → backlog. A failure applies in order, after the parked
  patches.

  The park is unconditional (every replayed backlog), not keyed on
  hydration being in progress at materialization: the projection's first
  compute runs at creation, materialization precedes the frame's claim
  window, and a claim made AFTER hydration-done — an occurrence inside a
  server <Loading> whose fragment reveals after done (corollary 4: the
  server's inner loading state registers nothing) — has no hydration state
  that says "claim". Keyed on `isHydrationInProgress()` the harness kept
  7 / 7 such cases red on the two seeds. A fresh mount pays one beat for
  not being told apart: its backlog lands a microtask after the snapshot,
  before any paint.

- The projection's root is DETACHED (`runWithOwner(null, createRoot)`):
  rooted under the reading owner, a trace revived at t=0 consumed one child
  id while one revived by a late claim consumed none, and a keyed sibling
  after the frame hydrated under diffe... (continued)

Coverage Stats

669 of 952 branches covered (70.27%)

Branch coverage included in aggregate %.

48 of 53 new or added lines in 1 file covered. (90.57%)

1 existing line in 1 file now uncovered.

989 of 1219 relevant lines covered (81.13%)

28.44 hits per line