esnet-security / SCRAM / 37662592413

90%

develop: 94%

push

github

feat(websockets): dynamically support multiple action_types (#249)

This PR cleans up a bunch of architectural stuff around websockets.
Effectively this moves us from the WebSocketMessage and
WebSocketSequenceElement models and just makes that an inherent part of
ActionType. Now websocket messages are method on the action model, so
all translator communications happen in one place (ehhh more or less,
the WUI checks are still an exception). This also adds a new
TranslatorType model that is basically just a string. This then is how
the translator websocket url is defined, and now you can link multipel
action types to a translator *and* multiple translators to a single
action type (if you want to say, migrate from a GoBGP translator to an
FRR translator, you could run them both for the `block` action and
they'd get the message).

Anyways, this is a big ugly change and I haven't updated the docs yet,
but it's here and it's running and it works well at least. It is
somewhat of a departure from the translator design (that didn't ever
actually work) where you'd just have one translator with multiple
"action" branches, because it implies you might at some point create
multiple translator instances that do different things.

There are also a few strays in here, namely changing the ports for local
dev to make more sense and cleaning up some log noise that makes
development hard.

We also need to update our ansible stuff to handle the new websockets
url for the translator

closes #254

130 of 182 branches covered (71.43%)

Branch coverage included in aggregate %.

1379 of 1499 relevant lines covered (91.99%)

0.92 hits per line