kubeflow / sdk / 37651703853

85%

push

github

feat(spark)!: delegate SparkApplication driver service account to the Spark Operator (#776)

* fix(spark): remove hardcoded default service account for SparkApplication driver

The Spark Operator now provides a fallback service account mechanism for
the SparkApplication driver spec (kubeflow/spark-operator#3092), so the
SDK no longer needs to hardcode `spark-operator-spark` as the default.
This keeps the SDK decoupled from operator cluster-admin concerns while
still allowing callers to override the service account via
`Driver.service_account`.

Signed-off-by: adibmbrk <adibmbrk@gmail.com>

* Update kubeflow/spark/backends/kubernetes/utils.py

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update kubeflow/spark/backends/kubernetes/utils.py

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update kubeflow/spark/backends/kubernetes/utils_test.py

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update kubeflow/spark/backends/kubernetes/utils_test.py

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update examples/spark/README.md

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update docs/source/spark/index.rst

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* Update kubeflow/spark/backends/kubernetes/utils_test.py

Co-authored-by: Tariq Hasan <mmtariquehsn@gmail.com>
Signed-off-by: Adib Mubarak <121048412+adibmbrk@users.noreply.github.com>

* fix(spark): pass through driver service account when configured

get_spark_job_driver_spec previously ignored driver.service_account... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

6316 of 7439 relevant lines covered (84.9%)

1.7 hits per line