mongodb-js / devtools-shared / 37644196777

80%

push

github

fix(mongodb-runner): reserve SLS host ports to avoid compose collisions (#912)

createSLSMultiCellEnvironment allocated host ports one at a time with
allocatePort(), which closes the socket before returning. Sequential
calls could therefore be handed the same ephemeral port, making
`docker compose up` fail with "port is already allocated" and aborting
the cluster startup.

Add allocatePorts(), which allocates a batch of distinct ports and holds
the sockets open until release(). createSLSMultiCellEnvironment now
allocates all of the compose file's host ports at once and exposes
releasePorts(); MongoCluster releases them via a new beforeComposeUp hook
immediately before `docker compose up`, and on any startup failure before
compose starts. The custom-backend docs now wire beforeComposeUp.

2435 of 3346 branches covered (72.77%)

Branch coverage included in aggregate %.

5017 of 6000 relevant lines covered (83.62%)

688.81 hits per line