kubernetes-sigs / azuredisk-csi-driver / 37610513179

74%

master: 74%

Build Type

Pull #3861

github

Committed by hasethuraman

Commit Message

fix: treat nil CompletionPercent as complete only after observed progress

Azure's Disk RP stops populating armcompute.DiskProperties.CompletionPercent
once a SKU migration's background copy finishes. checkMigrationProgress
previously defaulted a nil CompletionPercent to 0%, so the
migration-in-progress label was never removed and SKUMigrationCompleted
was never emitted once the migration actually completed.

Fix: track whether a real (non-nil) CompletionPercent has ever been
observed for a migration task. A nil value is only treated as 100%
complete if real progress was previously observed for that task;
otherwise we keep polling. This avoids prematurely declaring a migration
complete based on SKU alone (a disk can already report the target SKU
without a migration ever having run, e.g. when created from a snapshot
of a disk with that SKU already applied).

Pull Request Pull Request #3861: fix: treat nil CompletionPercent as complete only after observed progress

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

5788 of 7774 relevant lines covered (74.45%)

14.19 hits per line