opendefensecloud / solution-arsenal / 37611577630
79%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 94
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.58%. Remained the same
37611577630

push

github

web-flow 
fix: force checkout of local module clones on version change (#846)

## What
Forces the checkout of local module clones in
`hack/use-local-modules.sh`, so `make codegen` works again after k8s.io
version bumps.

## Why
openapi-gen writes `zz_generated.model_name.go` into
`k8s.io/api/core/v1`. The clone in `bin/.modules` therefore has local
changes after every codegen run. As long as the k8s.io version stays the
same this goes unnoticed. Once `go.mod` requires a new version (e.g.
`v0.36.2` → `v0.37.1`), `git checkout` refuses to overwrite the modified
file, and `make codegen` fails with:
```
      ✗ Failed to checkout version v0.37.1 for k8s.io/api
```
The real git error was hidden by `2>/dev/null`, so the only way to
recover was to delete `bin/.modules` by hand.

## Testing
- Checked out an old version of solution-arsenal, that was still on
v0.36.2
- Run `make codegen`
- Confirmed the local changes in `bin/.modules`
- Update to the latest version of solution-arsenal
- Run 'make codegen'
- Confirmed that the newer version of k8s.io/api has been checked out

## Checklist
- [x] ~Tests added/updated~ n/a
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Module setup now switches existing clones to the requested version,
replacing any local changes in those clones. Errors encountered while
checking out a newly cloned module are also shown instead of being
suppressed. These updates affect the module setup workflow and do not
change application features.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

5081 of 6466 relevant lines covered (78.58%)

26.14 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
86.64
-0.43% pkg/controller/rendertask_controller.go
2
77.08
0.2% pkg/controller/target_controller.go
Jobs
ID Job ID Ran Files Coverage
1 37611577630.1 94
78.58
GitHub Action Run
Source Files on build 37611577630