solidjs / solid / 37597810973

76%

main: 89%

push

github

fix(web): end cancelled chunk streams cleanly and validate chunk headers (#3846)

* fix(web): end cancelled chunk streams cleanly and validate chunk headers

- `cancel()` now ends a pending `next()` as done even partway through a
  frame. It used to throw "Malformed server function stream." whenever the
  cancel landed mid-frame. Frames reported a superseded response with that
  message instead of the supersession reason.
- A chunk header must be exactly `;0x` plus 8 hex digits plus `;`. The old
  `parseInt` read accepted wrong delimiters and trailing junk such as
  `;0x5zzzzzzz;`.
- Payloads are decoded with a fatal UTF-8 decoder, so invalid bytes fail
  as a malformed stream instead of becoming U+FFFD.
- `drain()` and a failed first frame in `deserializeStream` cancel the body
  instead of leaving it locked and unread.
- The reader drops an oversized store once it holds no unread bytes. One
  large frame used to keep its doubled allocation until the stream ended.
- `createChunk` refuses a payload whose length does not fit the 8-digit
  header. One encoder and one decoder are shared at module level.

The wire format is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(web): release a large chunk's store right away and recheck cancel after each read

- `releaseStore` now shrinks a store over 64 KiB to its unread bytes after
  every frame. The old rule compared the store with four times the frame
  just read. A store that grew to fit one frame is at most about twice that
  frame, so it was never released right after it. A connection that went
  idle after a large frame kept the allocation until the stream ended.
- A steady stream of frames over 64 KiB now regrows its store for each one.
  Frames under 64 KiB never shrink it, so the #3154 steady state for small
  frames is unchanged.
- `next()` checks `cancelled` after every read, not only on entry. A read
  that had already resolved with data when `cancel()` ran used to finish
... (continued)

654 of 932 branches covered (70.17%)

Branch coverage included in aggregate %.

964 of 1199 relevant lines covered (80.4%)

28.17 hits per line