tarantool / tarantool / 37595893309

88%

push

github

build: fix OpenSSL 3.0+ version detection

The `FindOpenSSL.cmake` module tries to parse the OpenSSL version from
the `OPENSSL_VERSION_NUMBER` macro definition from OpenSSL's header
assuming that the version is written verbatim:

```c
# define OPENSSL_VERSION_NUMBER  0x1010117fL
```

However, OpenSSL since v3 writes it as an expression, here from 3.6.4:

```c
/* Synthesize OPENSSL_VERSION_NUMBER with the layout 0xMNN00PP0L */
# define OPENSSL_VERSION_NUMBER          \
    ( (OPENSSL_VERSION_MAJOR<<28)        \
      |(OPENSSL_VERSION_MINOR<<20)       \
      |(OPENSSL_VERSION_PATCH<<4)        \
      |0x0L )
```

As a result, the version detected by this CMake module is an empty
string.

This is harmless for our build and it seems to affect only build logs.

Anyway, it may be confusing and it hit me once in a local experiment, so
I want to fix it. This commit copies the OpenSSL v3 version detection
code from upstream's `FindOpenSSL.cmake`: see [1] and [2].

[1]: https://gitlab.kitware.com/cmake/cmake/-/commit/61d746e59
[2]: https://gitlab.kitware.com/cmake/cmake/-/commit/796b44737

NO_CHANGELOG=build
NO_DOC=build
NO_TEST=build
NO_DEPS_UPDATE

72398 of 121234 branches covered (59.72%)

108781 of 123682 relevant lines covered (87.95%)

1416580.87 hits per line