solidjs / solid / 37591051975

76%

main: 89%

push

github

fix(signals): a Loading mounted under a hold shows its fallback (L2 regression of #3540) (#3824)

* fix(signals): a fresh Loading over a held value shows its fallback in a flush (#3540, L2 regression)

L2 regressed A29's boundary exemption in two ways:

- In a flush, a first pass under a loading boundary that has not shown
  content joined the flush to the hold it read, so the whole tick (the
  Show that mounted the boundary included) waited for the hold. A first
  pass that reads a hold now asks the boundaries up its chain
  (GlobalQueue._fresh); one such boundary catches it, and the pass joins
  pass-scoped (passTx), as a mount outside a flush does: the boundary's,
  not the tick's. A derivation outside the boundary in the same flush
  still holds the tick. A flush that set passTx clears it at its end.
- A render effect born held under a fresh loading boundary (content bound
  in JSX: the tree never reads the held value) was not caught, so the
  boundary revealed empty content, in a flush and out of one. It is now
  collected as a reader, and the output's first pass shows the fallback
  whenever the boundary has collected readers.

Refs #3540

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): the first-pass catch asks only the nearest loading boundary, and only one that has not shown content (#3540)

A revealed boundary (re-armed by `on` or not) neither catches nor records
a never-committed first pass, and no boundary past the nearest is asked:
which boundaries catch what is unchanged beyond A29's boundary exemption.
catchStatus is back to next's.

Refs #3540

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): ask the nearest loading boundary through _catch; no new hook (#3540)

A pass that read a hold asks GlobalQueue._catch with STATUS_UNINITIALIZED
in its flags. Only a first pass is caught, and only by the nearest loading
bou... (continued)

654 of 932 branches covered (70.17%)

Branch coverage included in aggregate %.

964 of 1199 relevant lines covered (80.4%)

28.28 hits per line