solidjs / solid / 37511332406

89%

push

github

fix(server): reassign Suspense completed closure on each render to prevent stale capture (#3745)

* fix(server): reassign Suspense completed closure on each render to prevent stale capture

* fix(server): settle nested Suspense from its latest render without hanging

Reassigning completed per render (previous commit) left the boundary's
fragment registered by an earlier render pending when a later render
resolved inline, and the stale completed then called an undefined done,
so renderToStringAsync never settled when the inner resource resolved
first. Keep the registered done on the shared boundary state, settle a
pending fragment on inline resolution, and make completed a no-op once
resolved. Adds tests for both resolution orders under renderToStringAsync
and renderToStream.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

1224 of 1452 branches covered (84.3%)

Branch coverage included in aggregate %.

1456 of 1555 relevant lines covered (93.63%)

139402.22 hits per line