accordproject / template-engine / 37498790105

73%

push

github

fix: draft() can't resolve TypeScript helper functions defined in logic/logic.ts (#147) (#150)

* fix: draft() can't resolve TypeScript helper functions defined in logic/logic.ts (#147)

TemplateArchiveProcessor.draft() compiled inline formulas (`{{% expr %}}`)
with a TypeScript context that did not include the template's user code
from `logic/logic.ts`. Helper functions like `monthlyPaymentFormula(...)`
therefore produced `Cannot find name 'monthlyPaymentFormula'` (TS2304).

trigger() and init() already loaded logic/logic.ts via the
TypeScriptToJavaScriptCompiler. This change:

- Extracts that compilation into a shared `compileUserLogic` helper
  (src/UserLogic.ts) which returns the compiled JS along with the
  top-level identifiers it declares.
- Adds `declare const <name>: any;` stubs to the formula compile
  context for each of those identifiers, so user helpers resolve at
  compile time.
- Splices the stripped logic.ts JS into the formula function body at
  runtime, so the same identifiers are real values at evaluation time.
- Refactors trigger() and init() to use the new shared helper, so
  draft() and trigger()/init() now use the same logic-loading path.

Adds a fixture (test/archives/formula-uses-logic-helper) and a unit
test that confirms draft() can call helpers from logic/logic.ts.

Signed-off-by: Claude <noreply@anthropic.com>

* fix: fully escape user logic symbol names when building regex

Addresses the CodeQL incomplete-escaping finding in usesUserLogic.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012UGdBxqqBziX4u42rcjxRA
Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Matt Roberts <code@rbrts.uk>
Co-authored-by: Claude <noreply@anthropic.com>

717 of 1137 branches covered (63.06%)

Branch coverage included in aggregate %.

69 of 73 new or added lines in 6 files covered. (94.52%)

1263 of 1588 relevant lines covered (79.53%)

2917.3 hits per line