fhunleth / muontrap / 296e2544-f02c-429e-a2dd-547e5fed481a

86%

push

circleci

Fix Argus warning by simplifying Task.async

This fixes:

```
warning[argus.mailbox]: Async task never awaited
    ╭─[lib/muontrap/daemon.ex:270:7]
    │
268 │     case Map.get(options, :wait_for) do
269 │       nil -> {:ok, start_port(state)}
270 │       fun -> {:ok, %{state | wait_task: Task.async(fun)}}
    •       ─────────────────────────┬─────────────────────────
    •                                ╰── task started here
271 │     end
272 │   end
    │
    ╰─────
      note: MuonTrap.Daemon.init/1 starts a task with Task.async (or async_nolink) but nothing awaits or yields it. Task.async links to the caller and always sends a result message: a crashing task takes the caller down, and completed results accumulate unread in the mailbox.
      help: consume the result with `Task.await/2` (or `Task.yield/2` plus `Task.shutdown/1`), or use `Task.Supervisor.start_child/2` for fire-and-forget work
```

We only need to know when the process is done, so this saves cleaning up
the mailbox while still propogating a crash if that happens.

6 of 6 new or added lines in 1 file covered. (100.0%)

246 of 285 relevant lines covered (86.32%)

1686.38 hits per line