aio-libs / multidict / 37470302828

86%

push

github

Drop inline from eighteen C helpers (#1707)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `inline` from eighteen helpers, leaving them plain `static`:
`md_ci_kind_for_first_key()`, `md_fresh_kind()`, `md_len()`,
`md_next_kind()`, `md_pop_all()`, `md_to_dict()`, `get_mod_state()`,
`get_mod_state_by_def()`, `get_mod_state_by_def_checked()`,
`_init_iter()`, `md_entries_capacity()`, `update_marks_moved()`,
`_md_pool_for()`, `bitmap_init()`, `bitmap_move()`, `bitmap_nbits()`,
`bitmap_next()` and `bitmap_release()`. GCC already ignored the hint for
all of them, so the generated code does not change; the inlining
decision is simply left to the compiler, as in #1689-#1691 and #1702.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Codegen: on 3.14.7t the `.text` disassembly of a release build of this
branch is byte-identical to one of c454ff92 (`size`: 267183 text on
both). The same four helpers are out of line before and after
(`bitmap_next`, `get_mod_state_by_def_checked.isra.0`,
`md_pop_all.constprop.0`, `md_to_dict.constprop.0`); the others stay
inlined. Identical code, so no callgrind run.

Tests: `pytest -q` on 3.10.17 (4093 passed) and 3.14.7t (4074 passed).
Pure-Python leg not run, no Python change. `tools/check_inlining.py`
passes on 3.14.7 and 3.14.7t. Pre-commit a... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line