supabase / supabase-flutter / 37468786125

92%

push

github

fix(postgrest): key long JSON paths by a SHA-256 digest of the expression (#1924)

Follow-up to #1915.

A JSON path longer than the 63 bytes Postgres keeps of a name gets a
response key made of a prefix and a hash of the whole expression. That
hash was `hash * 31 + byte`, which collides whenever two adjacent bytes
`(x, y)` become `(x + 1, y - 31)`, for example `aB` and `b#`. Two long
paths sharing the kept prefix could then end up with the same key and
read each other's value.

The suffix is now the first 16 hexadecimal characters of a SHA-256
digest of the expression. `crypto` is added as a direct dependency of
`postgrest`; it was already in the workspace through `supabase_common`.

Regression tests cover two long paths that differ only by `aB` and `b#`
past the kept prefix, both as a unit test on the response keys and as an
integration test reading both values back from PostgREST.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Long JSON-path keys that share the same first 63 characters now
produce distinct response keys, helping ensure each path returns its
corresponding value.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

1 of 1 new or added line in 1 file covered. (100.0%)

9309 of 10176 relevant lines covered (91.48%)

5.18 hits per line