supabase / supabase-flutter / 37467066164

92%

push

github

fix(typegen): suffix a member named like a generated type (#1921)

## Summary

A column named like its own enum type generates a file that does not
compile when the name starts with a digit.

```sql
create type "2fa_method" as enum ('totp', 'sms');
create table logins ("2fa_method" "2fa_method" not null);
```

```dart
extension type const LoginsRow(Map<String, dynamic> _json) implements Object {
  $2faMethod get $2faMethod => $2faMethod.fromWire(_json['2fa_method'] as String);
```

```
error - Undefined class '$2faMethod'. - undefined_class
error - The name '$2faMethod' isn't a type, so it can't be used as a type argument. - non_type_as_type_argument
```

Type names are PascalCase and members are camelCase, so the two normally
cannot meet. A name that starts with a digit is the exception: both get
a `$` in front and are otherwise spelled the same, so the getter
`$2faMethod` hides the enum `$2faMethod` inside the row type, and the
column constant does the same inside the namespace class. A relation
member can hide a row type the same way (`2fa_row` next to a table
`2fa`).

The member sets already reserve some type names one by one: the table's
own row, insert, update and namespace types, and since #1914 `int`,
`double`, `num` and `bool`. This change replaces those lists with one
rule: a member takes no name the type registry has handed out.
`_TypeNameRegistry` already holds every such name, the generated types
and the ones the source references, so the four reservations (row
members, column constants, computed fields, relations) now read from it
and `_coreTypeNames` is no longer needed.

For the schema above the member becomes `$2faMethod$`, suffixed like
every other taken name:

```dart
  $2faMethod get $2faMethod$ => $2faMethod.fromWire(_json['2fa_method'] as String);
```

Output for existing schemas does not change: both goldens are untouched
and their tests pass. The rule is slightly wider than strictly needed. A
member is also suffixed when the ty... (continued)

9 of 9 new or added lines in 1 file covered. (100.0%)

9308 of 10175 relevant lines covered (91.48%)

5.15 hits per line