supabase / supabase-flutter / 37461520337

92%

push

github

fix(typegen): generate a decoder for an enum named without ASCII letters (#1919)

## Summary

The generator throws instead of writing a file when a column uses an
enum whose name has no ASCII letter or digit, for example one named in
Cyrillic or in kanji.

```sql
create type "статус" as enum ('новый', 'готов');
create table orders (status "статус" not null);
```

```
RangeError (index): Invalid value: Valid value range is empty: 0
#0      _StringBase.[]
#1      _decoderName (package:supabase_typegen/src/dart_generator.dart:972:18)
#2      _DecoderRegistry.claim.<anonymous closure>
```

Such a name has no word `pascalCase` can use, so the enum is generated
as `$`, and that part works. `_decoderName` then builds the name of the
column's decoder from the Dart type and removes every `\W` character on
the way. `$` is not a word character, so nothing is left of the type
name and `base[0]` reads past the end of an empty string.

The fix names the decoder `_fromJson` when the type leaves no characters
to name it after. `_claimName` keeps a second enum of this kind apart,
as it does for every other decoder.

Only a schema that threw before is affected. For every schema that
generated before, the output is unchanged: the only edits to the hostile
golden are the lines for the new enum and table.

One related case stays open and is not touched here: when the columns of
a table are named in such a script too, a column getter named `$`
shadows the enum type `$` inside the row type, and the generated file
does not analyze. I can send that separately.

## Test

- `hostile_fixture.dart` gains the enum `статус` and an `orders` table
with a column of that type, and the checked-in golden gains their
output, so the package's own `dart analyze` run covers the generated
code.
- `dart_generator_test.dart`: `an enum named without ASCII letters gets
a decoder`.
- Without the one-line fix, every test that generates the hostile schema
fails with the `RangeError` above (20 tests)... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

9277 of 10144 relevant lines covered (91.45%)

5.13 hits per line