urwid / urwid / 37439321708

89%

Build Type

push

github

Committed by web-flow

Commit Message

Fix vterm hangs, crashes and leaks (#1406)

Fix defects found in a scan of urwid.vterm, and in the SGR colour code
it shares with ansi_parser.

- ICH/DCH/IL/DL counts are bounded by the screen, IL drops the bottom
  line of the region, IL/DL outside the region are ignored, and an
  explicit row given to insert_lines/remove_lines is honoured.
- CSI and OSC bodies are capped by ansi_parser.MAX_CSI_LENGTH and
  MAX_OSC_LENGTH, now public, and buffered in a bytearray.
- Invalid UTF-8 in an OSC title no longer raises.
- feed() and wait_and_feed() read the blocking pty master only when
  select() reports data.
- terminate() escalates signals only while the child runs, never
  signals a reaped pid, hangs up a setuid child it may not signal,
  works before spawn, drops its atexit hook and restores tty keys.
- A failed exec exits the forked child with 127.
- change_focus() saves the tty signal keys only on a focus change.
- resize() keeps the cursor on its line and adds cells without
  attributes; scrollback is shown at the current width, padded the
  same way.
- HT keeps the cell under the cursor, and ED 1 erases through it.
- ctrl keys with no C0 control character are returned unhandled.
- sgi_params_to_attrspec keeps a palette colour beside a true colour
  and bright colours under other attributes; AttrSpec.get_rgb_values
  decodes RGB per channel.

Coverage Stats

4653 of 5454 branches covered (85.31%)

Branch coverage included in aggregate %.

136 of 153 new or added lines in 3 files covered. (88.89%)

6 existing lines in 1 file now uncovered.

11716 of 13068 relevant lines covered (89.65%)

9.16 hits per line