FlexMeasures / flexmeasures / 37434658417

87%

push

github

fix: order an asset's sensors by id (#2637)

* fix: order an asset's sensors by id

Without an ORDER BY, PostgreSQL returns the rows in physical order, which drifts from
insertion order once the sensor table has a history of updates, so asset.sensors[0]
could be any of the asset's sensors.

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* docs/changelog: link PR #2637 in the sensor order entry

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* docs: remove asset sensor warning

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* docs/changelog: drop the duplicated sensor-order entry and its pointer to the removed warning

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HxCzxovkN1AXENWry1ZLjQ
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: order every unordered collection of related objects by id

The argument for ordering an asset's sensors holds for every list of related objects:
without an order, a list comes in whatever order the database returns, which can change after an update.
All 23 collections of objects with an integer id that had no order now list them by id;
the collections that already had an order of their own keep it, and beliefs have no id to order by.
A test fails for any new collection that is left without an order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HxCzxovkN1AXENWry1ZLjQ
Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

20946 of 24263 relevant lines covered (86.33%)

0.86 hits per line