kontron / python-ipmi / 37433332123

93%

Build Type

push

github

Committed by hthiery

Commit Message

interfaces/rmcp: discard late responses instead of re-queuing them

A received message that did not match the request was put into a queue
and taken out again as the first message of the next receive. A late
response of an earlier request (e.g. one that timed out on a slow BMC)
therefore poisoned the connection: every following request read the
stale message instead of its own response from the socket and failed
with a RetryError.

Requests are serialized by the transaction lock, so a message that does
not match the current request can never be needed again. Discard it and
keep reading until the matching response arrives or the timeout expires.
Unrelated messages no longer count as retries; max_retries only counts
timeouts.

In 0.4.2 the same queue logic looped forever, because the receive loop
was not bounded and the keep-alive thread read the socket without a
lock.

Update the description of the rmcp_ignore_rq_seq quirk, the
"Max retry while checking received data" error no longer exists.

Closes #169

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Coverage Stats

14 of 18 new or added lines in 1 file covered. (77.78%)

1 existing line in 1 file now uncovered.

7323 of 8021 relevant lines covered (91.3%)

5.47 hits per line