IBM / unitxt / 37422977924

78%

push

github

fix: Raise a clear error when HFSystemFormat's tokenizer has no chat template (#1983)

* fix: Raise a clear error when HFSystemFormat's tokenizer has no chat template

HFSystemFormat failed on every instance with the generic transformers
ValueError when the model's tokenizer does not define a chat template.
Check this once in prepare() and raise a UnitxtError naming the model and
how to proceed: use a model with a chat template, pass one explicitly via
chat_kwargs_dict={'chat_template': ...}, or use SystemFormat.

Signed-off-by: Waleed Khalid <wak327@gmail.com>

* test: Skip llmevalkit-based tool calling metric tests when llmevalkit is missing

ReflectionToolCallingMetric and ReflectionToolCallingMetricSyntactic
require llmevalkit, an internal package that CI installs only when the
repository secrets are available. Since #1989, pull requests from forks
and Dependabot skip that install, so the 15 tests constructing these
metrics errored with MissingRequirementsError and failed the unittests
and eager jobs. Skip them when llmevalkit is not installed; they still
run wherever it is.

Signed-off-by: Waleed Khalid <wak327@gmail.com>

---------

Signed-off-by: Waleed Khalid <wak327@gmail.com>
Co-authored-by: Yoav Katz <68273864+yoavkatz@users.noreply.github.com>

2785 of 4018 branches covered (69.31%)

Branch coverage included in aggregate %.

10975 of 13551 relevant lines covered (80.99%)

0.81 hits per line