node-opcua / node-opcua / 37418801941

91%

Build Type

push

github

Committed by erossignon

Commit Message

fix(transport): keep the packet assembler across a limits change

setLimits() reinstalled the PacketAssembler and removed the old one's
listeners. When the limits are negotiated from a chunk handler (the HEL on
the server, the ACK on the client) the old assembler is still inside feed()
with the rest of the same socket read, and the bytes that follow were then
emitted to an assembler with no listeners, throwing an unhandled 'error'.

Adjust the chunk-size limit in place via the new setMaxChunkSize(), and have
the assembler's own listeners ignore events once it is no longer current.

Coverage Stats

24858 of 30116 branches covered (82.54%)

33 of 33 new or added lines in 2 files covered. (100.0%)

843 existing lines in 8 files now uncovered.

205850 of 224164 relevant lines covered (91.83%)

199366.18 hits per line