kubeflow / trainer / 37410687532

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(runtimes): do not panic on nil NumProcPerNode in Flux plugin (#4159)

* fix(runtimes): do not panic on nil NumProcPerNode in Flux plugin

The numProcPerNode kubebuilder default on FluxMLPolicySource is only
applied by the API server, so objects constructed in-process leave the
field nil and generateFluxEntrypoint panics when the TrainJob does not
set numProcPerNode either. Resolve it with ptr.Deref against the
documented API default of 1.

Fixes #4053

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: 100-JM <272086397+100-JM@users.noreply.github.com>

* test(runtimes): simplify Flux defaulting test wording

Signed-off-by: 100-JM <272086397+100-JM@users.noreply.github.com>

---------

Signed-off-by: 100-JM <272086397+100-JM@users.noreply.github.com>
Co-authored-by: 100-JM <272086397+100-JM@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

3336 of 4621 relevant lines covered (72.19%)

0.84 hits per line