pomerium / envoy-custom / 37389474760

100%

push

github

use PackFrom() / UnpackTo() return value (#277)

As of protobuf v34.1 the Any proto PackFrom() and UnpackTo() methods
have gained the [[nodiscard]] attribute. Prepare for this change by
updating all our calls to these methods to use their return value.

Most calls are in tests, where we can add an EXPECT_TRUE or ASSERT_TRUE
to handle the return value. There are just a few such calls in the
production code. For the one UnpackTo() call, add an error check and a
corresponding unit test. For the PackFrom() calls, these should
basically never fail for messages constructed by this code, so add
RELEASE_ASSERTs checking the return value.

3472 of 4588 branches covered (75.68%)

12 of 12 new or added lines in 2 files covered. (100.0%)

7894 of 7894 relevant lines covered (100.0%)

19810.8 hits per line