Chia-Network / chia-blockchain / 37378050505

90%

Build Type

push

github

Committed by web-flow

Commit Message

Remove load_config_cli; convert its last caller (#21406)

Follow-up to #21283. After that PR, `load_config_cli` had one caller
left, `chia/simulator/start_simulator.py`, which still did the double
load (`load_config` for the whole file, then `load_config_cli` reloading
it for the `simulator` section). This switches it to
`apply_config_cli_overrides(config[SERVICE_NAME])` like every other
service and deletes `load_config_cli`. Nothing else used it, tests
included.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Small refactor of simulator config loading with no auth or data-path
logic changes beyond avoiding a redundant reload.
> 
> **Overview**
> Removes **`load_config_cli`** from `chia/util/config.py` now that
nothing calls it.
> 
> The simulator entrypoint **`start_simulator.py`** stops reloading
`config.yaml` for the `full_node` section. It now loads the file once
with **`load_config`**, applies CLI flags with
**`apply_config_cli_overrides(config[SERVICE_NAME])`**, and writes that
back into **`config[SERVICE_NAME]`**—the same pattern as farmer, full
node, and data layer startup.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
039532ae7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Coverage Stats

19927 of 24894 branches covered (80.05%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

33 existing lines in 6 files now uncovered.

117248 of 127072 relevant lines covered (92.27%)

1.85 hits per line