solidjs / solid / 37357631407

76%

main: 89%

push

github

fix(compiler): omit nullish class and style attributes in SSR (#3778)

Guard the entire dynamic attribute in Babel and the native compiler.
Evaluate its value once and keep the existing serializers for escaping
and non-null values. Preserve object literal paths and binding slots.

Add runtime coverage for nullish values, escaping, evaluation order and
hydration node reuse, and update the affected SSR fixture expectations.

Validation: 90 runtime/hydration cases, 271 Babel tests, Babel typecheck,
and the Rust feature matrix pass. Revalidation on next with the other
two fixes passed 6,047 compiler tests initially; seven timeouts passed
when the two affected files ran alone with a 15-second limit (216 tests).

Fixes #3773.

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.83 hits per line