mindersec / minder / 37354520397

63%

push

github

Add artifact-entity support for DockerHub and Quay providers (#6808)

* Add artifact-entity support for DockerHub and Quay providers

Implements SupportsEntity, GetEntityName, and FetchAllProperties for
ENTITY_ARTIFACTS on both providers, mirroring the existing OCI-embedding
pattern. Artifacts are identified by a <repo> or <repo>:<tag> reference
(tag defaults to latest), resolved to a digest via the embedded oci.OCI
client's GetDigest.

Verified DockerHub against a live docker.io registry (library/alpine:latest).

Part of #6779.

* Extract shared OCI artifact-parsing helpers, use provider-scoped upstream_id

Per review feedback on #6808: parseImageRef and artifactNameFromProperties
were duplicated between dockerhub.go and quay.go. Moved them to
internal/providers/oci/artifact.go as ParseImageRef,
ArtifactNameFromProperties, and NewArtifactProperties, since both
providers already depend on internal/providers/oci.

upstream_id is now <repo>@<digest> instead of a bare digest -- a bare
digest isn't unique within a provider (a mirrored image shares the same
digest as the original), so this pairs it with the repo name, which the
provider already scopes to a single namespace.

* Note webhook-driven artifact registration as a TODO

* Implement PropertiesToProtoMessage for DockerHub and Quay artifacts

Artifacts registered through these providers couldn't be converted to
a minderv1.Artifact, so reconcile, refresh and GetArtifact all failed
on a nil message.

Set Owner to the provider namespace and Name to the repository without
the tag, so the verifier builds <registry>/<namespace>/<repo>@<digest>.

108 of 130 new or added lines in 3 files covered. (83.08%)

22267 of 35502 relevant lines covered (62.72%)

40.42 hits per line