Logflare / logflare / 37344923926-1

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: bring spool S3/SQS adapters to parity with GCS/Pub-Sub (#4082)

* fix: bring spool S3/SQS storage/queue adapters to parity with GCS/Pub-Sub

Storage.S3.put/4 nested content-type/content-encoding under a :headers
key that ExAws.S3.put_object/4 doesn't recognize, so every S3-uploaded
spool file silently lost both headers (confirmed empirically — GCS's
adapter has always set Content-Type correctly, S3's never did). Fixes
that, adds the same content-encoding forwarding to GCS (previously
dropped there too), and gives spool's S3/SQS traffic its own dedicated
Finch pool (Logflare.FinchSpoolS3) instead of ExAws's default Hackney
client — mirroring GCS/Pub-Sub's existing dedicated FinchSpool pool,
and kept separate from the S3 destination backend adaptor's own
FinchS3 pool so the two don't contend.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: use Exception.t() instead of the nonexistent RuntimeError.t()

Dialyzer's typing check failed CI: RuntimeError.t/0 isn't a real type
(defexception doesn't auto-generate a t() type the way defstruct-only
modules sometimes manually declare one). pool_timeout?/1's second
clause also accepts any error, so Exception.t() is the correct — and
existing — type for what's actually passed at the one call site
(rescue error in RuntimeError -> ...).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test: update NetworkingTest for the new FinchSpoolS3 pool

Networking.pools/0's single-tenant-BigQuery-mode test asserted an
exact list of Finch pool names — missed when FinchSpoolS3 was added,
since I only ran the targeted spool/S3 test files rather than the
full suite (which would have caught this immediately).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: register spool's Finch pools in single-tenant Postgres mode too

A PR review bot caught this: Backends.Spool.DurableBuffer.Supervisor
and ConsumerSup start based solely on SPOOL_MODE, independent of
SingleTenant.postgres_backend?() ... (continued)

Coverage Stats

27 of 29 new or added lines in 6 files covered. (93.1%)

2 existing lines in 2 files now uncovered.

16028 of 19185 relevant lines covered (83.54%)

2753.21 hits per line