redhat-openshift-ecosystem / openshift-preflight / 37334527603

100%

push

github

check container: copy preflight.log into offline artifacts tar (CERTSA-78)

root.go's preRunConfig writes the offline log file once to the top-level
--artifacts directory, while the offline tar step only tars the
platform-specific subdirectory - so preflight.log was silently excluded
from every real --offline artifacts.tar, even though
submit-offline-artifacts requires it alongside cert-image.json/
results.json/rpm-manifest.json to submit results to Red Hat.

Add copyPreflightLogIntoDir, called from checkContainerRunE's offline
tar step, to copy the log into the platform-specific directory before
artifactsTar() is invoked. The log is always written as DefaultLogFile
(preflight.log) in the tar regardless of what --logfile was set to,
since submit-offline-artifacts and other consumers expect to find it by
that exact name. The destination file's permissions are explicitly set
to 0o600 via Chmod (not just OpenFile's mode, which only applies when a
new file is created) so a re-run with a pre-existing destination file
doesn't end up with looser permissions, matching how root.go writes the
original log.

Refs: CERTSA-78
Co-authored-by: Cursor <cursoragent@cursor.com>

36 of 36 new or added lines in 1 file covered. (100.0%)

6426 of 6426 relevant lines covered (100.0%)

160.86 hits per line