pomerium / pomerium / 37329156889

54%

Build Type

push

github

Committed by web-flow

Commit Message

close storage backend when stopping databroker server (#6837)

## Summary

I noticed this while doing the singleflight changes, but forgot to port
it to main directly.

When we use the in memory backend via `pkg/databroker/testutil.go`, we
expect

```go
srv := databroker.NewBackendServer(noop.NewTracerProvider())
t.Cleanup(srv.Stop)
```

to close the storage backend. As it stands pebble continues to run in
the background until all tests in the package finish, potentially
causing resource saturation issues.

This was also probably the intended behaviour of Stop(), but not closing
the backend very likely wasn't noticeable to end-users since the process
exits soon after that's called in `databroker/databroker.go`:
```go
func (d *DataBroker) Run(ctx context.Context) error {
  defer func() {
    health.ReportTerminating(health.DatabrokerCluster)
    d.srv.Stop()
  }()
  // ...
}
```

## Related issues

N/A

## User Explanation

N/A

## AI disclosure

none

## Checklist

- [X] reference any related issues
- [X] updated unit tests
- [X] add appropriate label (`enhancement`, `bug`, `breaking`,
`dependencies`, `ci`)
- [X] disclosed AI usage (or wrote "none") per AI_POLICY.md
- [X] ready for review

Coverage Stats

12 of 19 new or added lines in 1 file covered. (63.16%)

9 existing lines in 4 files now uncovered.

34816 of 65001 relevant lines covered (53.56%)

314.42 hits per line