supabase / supabase-flutter / 37318078784

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest): strip nulls on plain and single() responses (#1910)

## Description

`stripNulls()` appended `;nulls=stripped` to whatever `Accept` header
was set when it was called. That only worked for
`single().stripNulls()`:

- A plain `select().stripNulls()` sent
`application/json;nulls=stripped`, which PostgREST ignores. Only
`application/vnd.pgrst.array+json` and
`application/vnd.pgrst.object+json` honor the parameter.
- `stripNulls().single()` lost the flag because `single()` overwrites
`Accept`.
- The typed builders always hit the second case, since the executor
applies `stripNulls()` before the terminal `single()`.

`stripNulls()` now sets a flag on the request config, and the `Accept`
header is rewritten at execution time, matching supabase-js and
supabase-swift:

- No `Accept`, `application/json` or `application/vnd.pgrst.array+json`
becomes `application/vnd.pgrst.array+json;nulls=stripped`.
- `application/vnd.pgrst.object+json` gets `;nulls=stripped`.
- Parameters on a custom `Accept` header, such as `charset=utf-8`, are
kept, and an explicit `nulls=stripped` is not repeated.
- `stripNulls().explain()` explains the stripped media type in
`for="..."`.
- Other media types (CSV, GeoJSON) are left untouched.

Scalar RPC results are the same under the array media type, verified
against the local stack.

## Tests

- Fixed the two unit tests that asserted the ineffective header.
- Added header tests for `stripNulls().single()` (untyped and typed),
custom `Accept` parameters, an explicit `nulls=stripped`, `explain()`,
and CSV staying untouched.
- Added integration tests against the local stack for plain rows and
both call orders with `single()`. Six of the eight `stripNulls` tests
fail without the fix.

Fixes SDK-2121

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Null stripping works consistently for row and single-record responses,
regardless of call order.
* Requests use ... (continued)

Coverage Stats

20 of 20 new or added lines in 3 files covered. (100.0%)

32 existing lines in 2 files now uncovered.

9224 of 10093 relevant lines covered (91.39%)

5.13 hits per line