Kinto / kinto / 37303768629

100%

master: 100%

push

github

Fix KeyError in memory storage purge_deleted when resource is missing (#3793)

* Fix KeyError in memory storage purge_deleted when resource is missing

In the memory storage backend, purge_deleted() attempted to directly delete
resource timestamps and index tombstones assuming the resource_name key always
existed. When a resource had not recorded timestamps or tombstones (e.g. during
random heartbeat purge checks of '__heartbeat__'), this caused an unhandled KeyError
which led to heartbeat health check failures (storage: false).

This commit:
- Uses .pop(resource_name, None) on parent timestamps.
- Skips missing resources in tombstones mapping.
- Adds test_purge_deleted_works_when_resource_does_not_exist to StorageTest.

* Add Mallesh Pareet to CONTRIBUTORS.rst

---------

Co-authored-by: Mallesh Pareet <mallesh.pareet@encureit.com>

1589 of 1589 branches covered (100.0%)

10 of 10 new or added lines in 2 files covered. (100.0%)

8195 of 8195 relevant lines covered (100.0%)

3.0 hits per line