supabase / cli / 37289898470
67%
develop: 67%

LAST BUILD BRANCH: gh-readonly-queue/develop/pr-7132-02f0908acf0e21abd9f4818010abd97596ae32d6
DEFAULT BRANCH: develop
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.737%. Remained the same
37289898470

push

github

web-flow 
fix(config): stop treating disabled data api as enabled (CLI-2591) (#6949)

## TL;DR

fixes disabled data api detection in the shared mapping used by `config
diff`, `config push` and `config pull`

## what's hurting the users?

the v2 project config returns `pg_pgrst_no_exposed_schemas` when the
data api is disabled, but the mapping treated any nonempty value as
enabled

`config push` started hitting this in stable v2.117.0 when it switched
from the v1 `/postgrest` read to the shared v2 mapping

## fixed now by:

`remoteDataApiDisabled` recognizes both `""` and the exact marker. 
`api.enabled` now uses that same check as `schemas`, `extra_search_path`
and `max_rows`

<details>
<summary>before/after:</summary>

with local `api.enabled = false`, the remote marker, and no unrelated
drift:

| invocation | before | now |
| --- | --- | --- |
| `config diff --exit-code` | reports false api drift; exits 2 | no
differences; exits 0 |
| `config push --yes` | sends `{"db_schema":""}` again | api config is
up to date |
| `config pull --yes` | proposes enabling the api and importing the
marker as a schema | proposes no api changes |

</details>

explicit `api.enabled = true` now re-enables the api with default
schemas
custom schemas still work. schema-only changes with enablement
undeclared require an explicit enable request...
<details>
<summary>rep:</summary>

```mermaid
flowchart TD
    off["data api disabled"]
    off --> v1["v1: empty db_schema"]
    off --> v2["v2: platform marker"]

    v1 --> legacy["v2.116.0 push"]
    legacy --> disabled["reads disabled"]

    v2 --> shared["push from stable v2.117.0"]
    shared --> before["before: nonempty means enabled"]
    before --> wrong["reads enabled"]

    shared --> after["now: empty or exact marker means disabled"]
    after --> disabled
```

</details> 

## ref:

- closes #6932
- regression introduced in #6454

4097 of 6139 relevant lines covered (66.74%)

7.37 hits per line

Jobs
ID Job ID Ran Files Coverage
1 37289898470.1 79
66.74
GitHub Action Run
Source Files on build 37289898470