kubernetes-sigs / lws / 37286587861

85%

Build Type

push

github

Committed by web-flow

Commit Message

Name hash worker StatefulSets after the leader host name (#1126)

* Name hash worker StatefulSets after the leader host name

A hash leader has no pod name at admission, so its TPU_WORKER_HOSTNAMES listed workers as -1.<subdomain> and TPU_NAME was empty. Naming the worker StatefulSet after the leader host name, which admission sets, lets the leader compute its workers' names. Worker StatefulSets are now looked up by the leader host name in both modes, since it equals the pod name in Ordinal mode.

Same change as #1112 on release-0.11, plus the Group Identity docs.

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

* Use one leaderHostname variable in the TPU helpers

Workers are named after the leader host name, so the worker StatefulSet name and the leader host name are the same value. Keep a single leaderHostname instead of separate leader name and host name variables.

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

---------

Signed-off-by: Benjamin Braun <benjaminbraun@google.com>

Coverage Stats

34 of 34 new or added lines in 3 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

6235 of 7366 relevant lines covered (84.65%)

24972.21 hits per line