solidjs / solid / 37285287812

76%

main: 89%

push

github

fix(signals): compare symbol keys in UNSTABLE_MEMO_OUTPUT (#3775)

The unstable-output check compared plain objects by Object.keys, which
skips symbol keys. A memo that returns a fresh symbol-keyed box each run
looked like a run of empty objects, so it warned as new-but-equivalent
although every box held a different value. web's dynamic does this for
an in-flight promise ({ [FLIGHT]: promise }), so every refetch through
dynamic counted toward the warning.

shallowEquivalent now compares Reflect.ownKeys. Boxes whose symbol-keyed
values are identical still warn.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.82 hits per line