bleedingdeacons / freedom-sharp / 37283127192

83%

push

github

fix: read Android's dropped connection as Offline, and apply nothing when a values request fails (#9)

AndroidMessageHandler reports a dropped connection as WebException (inner
Java.Net.SocketException: Software caused connection abort), not
HttpRequestException. FreedomApi only caught the latter, so on the Register
tablet on 2026-10-04 a connection dropped as the app was backgrounded
escaped SyncAsync from the values request instead of returning Offline.

- FreedomApi treats WebException and IOException as no answer, alongside
  HttpRequestException and an unrequested timeout. No Android types are
  referenced; both are BCL.
- A values request that gets no answer or an error now abandons the whole
  sync: nothing is applied, not earlier batches nor removals, so the store
  stays exactly what its ETag describes and the next start retries cleanly.
  It is reported as the manifest request would have been (Offline,
  ServerError, ...), where before it came back UpToDate or Updated.

11 of 11 new or added lines in 2 files covered. (100.0%)

2369 of 2840 relevant lines covered (83.42%)

15.45 hits per line