fluent / fluent-plugin-opensearch / 37279291879

93%

main: 93%

Build Type

Pull #192

github

Committed by kenhys

Commit Message

out_opensearch: check a host placeholder value by its place

Before: a value could hold a host name and a port wherever the
placeholder was.

* `host myhost-${pipeline_id}` let a record field move the request to
  another domain
* `hosts https://logs-${pipeline_id}.example.com/os` let a value put a
  port in the middle of a name, which `URI()` cannot read
* An empty value dropped the host without an error
* An IPv6 address was rejected everywhere

After: what a value may hold depends on where the operator put the
placeholder.

* A value that continues a name fills in one label, or a sub domain when
  the operator wrote a fixed domain after it, so it cannot leave that
  domain or add a port
* A value that stands for the whole host name may hold a name and a port
* An IPv6 address is allowed where the operator wrote the "[]" or the
  scheme that `URI()` needs to read it
* An empty value is rejected everywhere

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>

Pull Request Pull Request #192: out_opensearch: limit what a host placeholder can expand to

Coverage Stats

48 of 49 new or added lines in 2 files covered. (97.96%)

19 existing lines in 1 file now uncovered.

1244 of 1336 relevant lines covered (93.11%)

329.29 hits per line